Misaki/GhostEngine
2
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(docking): enforce DockDocument children in DockGroup and fix style

Browse Source
This commit is contained in:
Misaki
2026-03-28 21:58:21 +09:00
parent 332a940993
commit 09576bb6e1
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Editor/Ghost.Editor/View/Controls/Docking/DockContainer.cs
View File

@@ -19,7 +19,7 @@ public abstract class DockContainer : DockModule
OnChildrenUpdated();
}
public void AddChild(DockModule module)
public virtual void AddChild(DockModule module)
{
ArgumentNullException.ThrowIfNull(module);
@@ -45,7 +45,7 @@ public abstract class DockContainer : DockModule
_children.Add(module);
}
public void RemoveChild(DockModule module)
public virtual void RemoveChild(DockModule module)
{
ArgumentNullException.ThrowIfNull(module);

11
src/Editor/Ghost.Editor/View/Controls/Docking/DockGroup.cs
View File

@@ -1,6 +1,5 @@
using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml.Controls;
using Microsoft.UI.Xaml.Data;
namespace Ghost.Editor.View.Controls.Docking;
@@ -16,6 +15,16 @@ public partial class DockGroup : DockContainer
DefaultStyleKey = typeof(DockGroup);
}
public override void AddChild(DockModule module)
{
if (module is not DockDocument)
{
throw new ArgumentException($"{nameof(DockGroup)} only accepts {nameof(DockDocument)} children.", nameof(module));
}
base.AddChild(module);
}
protected override void OnApplyTemplate()
{
base.OnApplyTemplate();