Misaki/GhostEngine
2
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(dock): ensure transactional tear-off and wire main window tabs

Browse Source
This commit is contained in:
Misaki
2026-03-28 16:05:51 +09:00
parent 304df0a381
commit 299bcf520c
3 changed files with 41 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/Editor/Ghost.Editor/View/Controls/DockLayout.cs
View File

@@ -299,23 +299,32 @@ public sealed partial class DockLayout : Control
private void TabView_TabDroppedOutside(Microsoft.UI.Xaml.Controls.TabView sender, Microsoft.UI.Xaml.Controls.TabViewTabDroppedOutsideEventArgs args)
{
if (_sourceNode != null && _draggedItem != null)
if (_sourceNode != null && _draggedItem != null && TabTornOff != null)
{
int originalIndex = _sourceNode.Items.IndexOf(_draggedItem);
if (originalIndex == -1)
{
ClearDragOperationState();
return;
}
// Remove from current tree
if (_sourceNode.Items.Remove(_draggedItem))
{
DockMutationEngine.CleanupEmptyNodes(_sourceNode);
try
{
// Raise event to let the host handle window creation
TabTornOff?.Invoke(this, new TabTornOffEventArgs(_draggedItem));
TabTornOff.Invoke(this, new TabTornOffEventArgs(_draggedItem));
// Only cleanup if the tear-off was successful (didn't throw)
DockMutationEngine.CleanupEmptyNodes(_sourceNode);
}
catch (Exception ex)
{
// Rollback: Re-insert the item if the tear-off handler fails
_sourceNode.Items.Add(_draggedItem);
Logger.LogError($"Failed to tear off tab: {ex.Message}");
// Rollback: Re-insert the item at original position if the tear-off handler fails
_sourceNode.Items.Insert(originalIndex, _draggedItem);
_sourceNode.SelectedItem = _draggedItem;
Logger.LogError(ex);
}
}