Misaki/GhostEngine
2
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(docking): address code quality issues in DockingLayout

Browse Source
This commit is contained in:
Misaki
2026-03-28 22:11:49 +09:00
parent 5521a8cce2
commit 4188152f49
1 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/Editor/Ghost.Editor/View/Controls/Docking/DockingLayout.cs
View File

@@ -3,7 +3,6 @@ using Microsoft.UI.Xaml.Controls;
namespace Ghost.Editor.View.Controls.Docking; namespace Ghost.Editor.View.Controls.Docking;
[TemplatePart(Name = "PART_Content", Type = typeof(ContentPresenter))]
[TemplatePart(Name = "PART_OverlayCanvas", Type = typeof(Canvas))] [TemplatePart(Name = "PART_OverlayCanvas", Type = typeof(Canvas))]
[TemplatePart(Name = "PART_Highlight", Type = typeof(DockRegionHighlight))] [TemplatePart(Name = "PART_Highlight", Type = typeof(DockRegionHighlight))]
public class DockingLayout : Control public class DockingLayout : Control
@@ -17,7 +16,9 @@ public class DockingLayout : Control
set => SetValue(RootPanelProperty, value); set => SetValue(RootPanelProperty, value);
} }
// Used in Task 5 for drag and drop highlight
private Canvas? _overlayCanvas; private Canvas? _overlayCanvas;
// Used in Task 5 for drag and drop highlight
private DockRegionHighlight? _highlight; private DockRegionHighlight? _highlight;
public DockingLayout() public DockingLayout()
@@ -50,7 +51,11 @@ public class DockingLayout : Control
public void AddDocument(DockDocument document, DockTarget target, DockGroup? targetGroup = null) public void AddDocument(DockDocument document, DockTarget target, DockGroup? targetGroup = null)
{ {
// TODO: Handle non-Center targets (Task 5) if (target != DockTarget.Center)
{
throw new NotImplementedException("Target docking will be implemented in Task 5");
}
if (RootPanel == null) if (RootPanel == null)
{ {
RootPanel = new DockPanel(); RootPanel = new DockPanel();
@@ -65,7 +70,18 @@ public class DockingLayout : Control
RootPanel.AddChild(group); RootPanel.AddChild(group);
return; return;
} }
targetGroup = RootPanel.Children[0] as DockGroup;
if (RootPanel.Children[0] is DockGroup existingGroup)
{
targetGroup = existingGroup;
}
else
{
var group = new DockGroup();
group.AddChild(document);
RootPanel.AddChild(group);
return;
}
} }
if (targetGroup != null) if (targetGroup != null)