Misaki/GhostEngine
2
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor error handling and improve type safety

Browse Source 
Refactored error handling across the codebase by replacing exceptions with `Result`-based error handling for better robustness and consistency.

- Updated `ResultExtensions` to use `EqualityComparer` for comparisons.
- Enhanced `RenderingContext` with `GetValueOrThrow` for resource validation and added type constraints for texture methods.
- Introduced `CommandError` and `RecordError` in `D3D12CommandBuffer` for improved error tracking.
- Refactored `D3D12ResourceDatabase` to use `Result` objects for resource queries.
- Updated `ICommandBuffer` and `IResourceDatabase` interfaces to return `Result` objects.
- Improved type safety by replacing `int` with `uint` where appropriate.
- Simplified texture handling in `MeshRenderPass` with new `CreateTexture` logic.
- Cleaned up project files by removing unused and redundant entries.

These changes enhance code maintainability, improve error reporting, and ensure type safety throughout the project.
This commit is contained in:
Misaki
2025-11-30 19:06:31 +09:00
parent 0ec318a9ab
commit 85280c746d
15 changed files with 244 additions and 126 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
Ghost.Graphics/Core/RenderingContext.cs
View File

@@ -102,8 +102,11 @@ public readonly unsafe ref struct RenderingContext
public void UploadMesh(Handle<Mesh> mesh, bool markMeshStatic)
{
ref var meshData = ref ResourceDatabase.GetMeshReference(mesh);
var vertexState = ResourceDatabase.GetResourceState(meshData.VertexBuffer.AsResource());
var indexState = ResourceDatabase.GetResourceState(meshData.IndexBuffer.AsResource());
var vertexState = ResourceDatabase.GetResourceState(meshData.VertexBuffer.AsResource())
.GetValueOrThrow(ResultStatus.Success);
var indexState = ResourceDatabase.GetResourceState(meshData.IndexBuffer.AsResource())
.GetValueOrThrow(ResultStatus.Success);
var needVertexTransition = vertexState != ResourceState.CopyDest;
var needIndexTransition = indexState != ResourceState.CopyDest;
@@ -149,7 +152,9 @@ public readonly unsafe ref struct RenderingContext
};
var bufferHandle = meshData.ObjectDataBuffer.AsResource();
var state = ResourceDatabase.GetResourceState(bufferHandle);
var state = ResourceDatabase.GetResourceState(bufferHandle)
.GetValueOrThrow(ResultStatus.Success);
var needTransition = state != ResourceState.CopyDest;
if (needTransition)
{
@@ -164,17 +169,31 @@ public readonly unsafe ref struct RenderingContext
}
}
public Handle<Texture> CreateTexture(ref readonly TextureDesc desc, bool tempResource = false)
public Handle<Texture> CreateTexture<T>(ref readonly TextureDesc desc, ReadOnlySpan<T> data, bool tempResource = false)
where T : unmanaged
{
return ResourceAllocator.CreateTexture(in desc, tempResource);
var handle = ResourceAllocator.CreateTexture(in desc, tempResource);
UploadTexture(handle, data);
return handle;
}
public void UploadTexture(Handle<Texture> texture, ReadOnlySpan<byte> data)
public void UploadTexture<T>(Handle<Texture> texture, ReadOnlySpan<T> data)
where T : unmanaged
{
var desc = ResourceDatabase.GetResourceDescription(texture.AsResource());
desc.TextureDescription.Format.GetSurfaceInfo((int)desc.TextureDescription.Width, (int)desc.TextureDescription.Height, out var rowPitch, out var slicePitch, out _);
var desc = ResourceDatabase.GetResourceDescription(texture.AsResource())
.GetValueOrThrow(ResultStatus.Success);
if (data.Length * sizeof(T) != desc.TextureDescription.GetTotalBytes())
{
throw new ArgumentException("Data size does not match texture size.");
}
desc.TextureDescription.Format.GetSurfaceInfo(desc.TextureDescription.Width, desc.TextureDescription.Height, out var rowPitch, out var slicePitch, out _);
var sateBefore = ResourceDatabase.GetResourceState(texture.AsResource())
.GetValueOrThrow(ResultStatus.Success);
var sateBefore = ResourceDatabase.GetResourceState(texture.AsResource());
var needTransition = sateBefore != ResourceState.CopyDest;
if (needTransition)
@@ -182,7 +201,7 @@ public readonly unsafe ref struct RenderingContext
_directCmd.ResourceBarrier(texture.AsResource(), sateBefore, ResourceState.CopyDest);
}
fixed (byte* pData = data)
fixed (T* pData = data)
{
var subresourceData = new SubResourceData
{