Misaki/GhostEngine
2
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(docking): address code quality issues in DockingLayout

Browse Source
This commit is contained in:
Misaki
2026-03-28 22:54:30 +09:00
parent 9738971369
commit c52daf3914
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Editor/Ghost.Editor/View/Controls/Docking/DockingLayout.cs
View File

@@ -32,6 +32,9 @@ public class DockingLayout : Control
private DockRegionHighlight? _highlight; private DockRegionHighlight? _highlight;
private readonly List<FloatingWindow> _floatingWindows = new(); private readonly List<FloatingWindow> _floatingWindows = new();
/// <summary>
/// Initializes a new instance of the <see cref="DockingLayout"/> class.
/// </summary>
public DockingLayout() public DockingLayout()
{ {
DefaultStyleKey = typeof(DockingLayout); DefaultStyleKey = typeof(DockingLayout);
@@ -127,6 +130,11 @@ public class DockingLayout : Control
int index = parentPanel.Children.IndexOf(targetGroup); int index = parentPanel.Children.IndexOf(targetGroup);
if (index < 0)
{
throw new InvalidOperationException("targetGroup not found in parentPanel");
}
if (parentPanel.Orientation == orientation) if (parentPanel.Orientation == orientation)
{ {
// Same orientation, just insert // Same orientation, just insert
@@ -248,6 +256,7 @@ public class DockingLayout : Control
internal void CreateFloatingWindow(DockDocument doc) internal void CreateFloatingWindow(DockDocument doc)
{ {
ArgumentNullException.ThrowIfNull(doc);
var window = new FloatingWindow(doc); var window = new FloatingWindow(doc);
_floatingWindows.Add(window); _floatingWindows.Add(window);
window.Closed += (s, e) => _floatingWindows.Remove(window); window.Closed += (s, e) => _floatingWindows.Remove(window);