Misaki/GhostEngine
2
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(dock): clean up unused variables and simplify event handling

Browse Source
This commit is contained in:
Misaki
2026-03-28 17:44:10 +09:00
parent c77592d479
commit ea7d3fad26
2 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Editor/Ghost.Editor/App.xaml.cs
View File

@@ -64,7 +64,7 @@ public partial class App : Application
AddSecondaryWindow(newWindow); AddSecondaryWindow(newWindow);
newWindow.Activate(); newWindow.Activate();
} }
catch (Exception ex) catch (Exception)
{ {
// Cleanup partially created window // Cleanup partially created window
if (Current is App app) if (Current is App app)

9
src/Editor/Ghost.Editor/View/Controls/DockLayout.cs
View File

@@ -434,7 +434,8 @@ public sealed partial class DockLayout : Control
// Validate that the item actually belongs to this source node before attempting tear-off // Validate that the item actually belongs to this source node before attempting tear-off
if (sourceNode.Items.Contains(args.Item)) if (sourceNode.Items.Contains(args.Item))
{ {
if (TabTornOff == null) var handler = TabTornOff;
if (handler == null)
{ {
Logger.LogWarning("Tab dropped outside but no TabTornOff subscribers found."); Logger.LogWarning("Tab dropped outside but no TabTornOff subscribers found.");
return; return;
@@ -442,12 +443,6 @@ public sealed partial class DockLayout : Control
var result = TabTearOffService.TryTearOffTab(sourceNode.Items, args.Item, (tab) => var result = TabTearOffService.TryTearOffTab(sourceNode.Items, args.Item, (tab) =>
{ {
var handler = TabTornOff;
if (handler == null)
{
throw new InvalidOperationException("No tear-off handler attached.");
}
// Raise event to let the host handle window creation // Raise event to let the host handle window creation
handler.Invoke(this, new TabTornOffEventArgs(tab, sourceNode)); handler.Invoke(this, new TabTornOffEventArgs(tab, sourceNode));
}, sourceNode); }, sourceNode);