Misaki/Misaki.HighPerformance
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor TLSFAllocator locking, update AddRange signatures

Browse Source 
Refactored TLSFAllocator to use a static lock instead of per-instance GCHandle-based locking, removing the Dispose method and related code. Updated allocation methods to use the static lock for thread safety. Removed Dispose call on s_pTLSFAllocator. In UnsafeChunkedList, removed an unused using directive and replaced explicit int types with var in AddRange. Changed UnsafeList<T>.AddRange to accept ReadOnlySpan<T> for broader compatibility. Bumped assembly version to 1.6.25.
This commit is contained in:
Misaki
2026-05-10 13:06:32 +09:00
parent 99a7e3c4e1
commit 4b9d93ec65
4 changed files with 10 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
Misaki.HighPerformance.LowLevel/Buffer/AllocationManager.cs
View File

@@ -141,10 +141,11 @@ public static unsafe class AllocationManager
}
// TODO: Lock-free implementation
internal struct TLSFAllocator : IAllocator, IDisposable
internal struct TLSFAllocator : IAllocator
{
private static readonly Lock s_lock = new Lock();
private TLSF _tlsf;
private GCHandle _lock;
private AllocationHandle _handle;
public readonly AllocationHandle Handle => _handle;
@@ -152,18 +153,14 @@ public static unsafe class AllocationManager
public void Init(nuint alignment, nuint initialChunkSize)
{
_tlsf = new TLSF(alignment, initialChunkSize);
#pragma warning disable CS9216 // A value of type 'System.Threading.Lock' converted to a different type will use likely unintended monitor-based locking in 'lock' statement.
_lock = GCHandle.Alloc(new Lock(), GCHandleType.Normal);
#pragma warning restore CS9216 // A value of type 'System.Threading.Lock' converted to a different type will use likely unintended monitor-based locking in 'lock' statement.
_handle = new AllocationHandle(Unsafe.AsPointer(in this), &Allocate, &Reallocate, &Free);
}
private static void* Allocate(void* state, nuint size, nuint alignment, AllocationOption allocationOption)
{
var allocator = (TLSFAllocator*)state;
var locker = (Lock)allocator->_lock.Target!;
lock (locker)
lock (s_lock)
{
return allocator->_tlsf.Allocate(size, alignment, allocationOption);
}
@@ -172,9 +169,8 @@ public static unsafe class AllocationManager
private static void* Reallocate(void* state, void* ptr, nuint oldSize, nuint newSize, nuint alignment, AllocationOption allocationOption)
{
var allocator = (TLSFAllocator*)state;
var locker = (Lock)allocator->_lock.Target!;
lock (locker)
lock (s_lock)
{
return allocator->_tlsf.Reallocate(ptr, oldSize, newSize, alignment, allocationOption);
}
@@ -183,18 +179,12 @@ public static unsafe class AllocationManager
private static void Free(void* state, void* ptr)
{
var allocator = (TLSFAllocator*)state;
var locker = (Lock)allocator->_lock.Target!;
lock (locker)
lock (s_lock)
{
allocator->_tlsf.Free(ptr);
}
}
public void Dispose()
{
_lock.Free();
}
}
private class ThreadLocalStackPool
@@ -513,7 +503,6 @@ public static unsafe class AllocationManager
if (s_pTLSFAllocator != null)
{
s_pTLSFAllocator->Dispose();
NativeMemory.Free(s_pTLSFAllocator);
s_pTLSFAllocator = null;
}